[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 4 17:18:29 UTC 2020


== Series Details ==

Series: Refactor Gen11+ SAGV support (rev2)
URL   : https://patchwork.freedesktop.org/series/72923/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
37ec63f7b6aa drm/i915: Start passing latency as parameter
bbfa09f48831 drm/i915: Introduce skl_plane_wm_level accessor.
18e583700e52 drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
also in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state

-:45: WARNING:LINE_SPACING: Missing a blank line after declarations
#45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:395:
+	struct intel_global_state *bw_state;
+	bw_state = intel_atomic_get_new_global_obj_state(state, &dev_priv->bw_obj);

-:89: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#89: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:72:
+_intel_atomic_init_global_obj_state(struct intel_atomic_state *state,
 				  struct intel_global_obj *obj)

-:108: CHECK:LINE_SPACING: Please don't use multiple blank lines
#108: FILE: drivers/gpu/drm/i915/display/intel_global_state.c:111:
 
+

total: 0 errors, 2 warnings, 2 checks, 109 lines checked
05c12cc8f8d9 drm/i915: Refactor intel_can_enable_sagv
-:77: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#77: 
      when using skl_plane_wm_level accessor, as we had previously for Gen11+

-:284: CHECK:LINE_SPACING: Please don't use multiple blank lines
#284: FILE: drivers/gpu/drm/i915/intel_pm.c:3820:
+
+

-:438: WARNING:LINE_SPACING: Missing a blank line after declarations
#438: FILE: drivers/gpu/drm/i915/intel_pm.c:3974:
+		int active_pipe_bit = dev_priv->active_pipes & BIT(i);
+		if (active_pipe_bit) {

-:641: WARNING:LONG_LINE: line over 100 characters
#641: FILE: drivers/gpu/drm/i915/intel_pm.c:5560:
+					    old_wm->sagv_wm0.min_ddb_alloc : old_wm->wm[0].min_ddb_alloc;

-:644: WARNING:LONG_LINE: line over 100 characters
#644: FILE: drivers/gpu/drm/i915/intel_pm.c:5563:
+					    new_wm->sagv_wm0.min_ddb_alloc : new_wm->wm[0].min_ddb_alloc;

-:732: WARNING:LONG_LINE: line over 100 characters
#732: FILE: drivers/gpu/drm/i915/intel_pm.c:5799:
+						 &new_crtc_state->wm.skl.optimal.planes[plane_id])) {

total: 0 errors, 5 warnings, 1 checks, 674 lines checked
5f8d124e82f6 drm/i915: Added required new PCode commands
5527e670a257 drm/i915: Restrict qgv points which don't have enough bandwidth.
4b30ba5d0b64 drm/i915: Enable SAGV support for Gen12



More information about the Intel-gfx mailing list