[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out display debugfs to a separate file

[Patchwork]

== Series Details ==

Series: drm/i915: split out display debugfs to a separate file
URL   : https://patchwork.freedesktop.org/series/72979/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f453df1c7174 drm/i915: split out display debugfs to a separate file
-:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

-:166: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63)
#166: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:137:
+	if (INTEL_GEN(dev_priv) >= 9)
+		/* no global SR status; inspect per-plane WM */;

-:513: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#513: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:484:
+static void intel_dp_mst_info(struct seq_file *m,
+			  struct intel_connector *intel_connector)

-:592: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#592: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:563:
+	seq_printf(m, "\tmodes:\n");

-:674: WARNING:LONG_LINE: line over 100 characters
#674: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:645:
+	seq_printf(m, "\t\thw: fb=%d,%s,%dx%d, visible=%s, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n",

-:775: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#775: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:746:
+	seq_printf(m, "CRTC info\n");

-:776: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#776: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:747:
+	seq_printf(m, "---------\n");

-:780: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#780: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:751:
+	seq_printf(m, "\n");

-:781: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#781: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:752:
+	seq_printf(m, "Connector info\n");

-:782: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#782: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:753:
+	seq_printf(m, "--------------\n");

-:809: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#809: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:780:
+		seq_printf(m, " tracked hardware state:\n");

-:916: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#916: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:887:
+				seq_puts(m,
+				"\tAs PSR is enabled, DRRS is not enabled\n");

-:923: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#923: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:894:
+		seq_printf(m, "\t\tBusy_frontbuffer_bits: 0x%X",
+					drrs->busy_frontbuffer_bits);

-:934: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#934: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:905:
+			seq_printf(m, "DRRS_State: Unknown(%d)\n",
+						drrs->refresh_rate_type);

-:1086: CHECK:BRACES: braces {} should be used on all arms of this statement
#1086: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1057:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:1092: CHECK:BRACES: Unbalanced braces around else statement
#1092: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1063:
+		} else

-:1136: CHECK:BRACES: braces {} should be used on all arms of this statement
#1136: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1107:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:1151: CHECK:BRACES: Unbalanced braces around else statement
#1151: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1122:
+		} else

-:1180: CHECK:BRACES: braces {} should be used on all arms of this statement
#1180: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1151:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:1183: CHECK:BRACES: Unbalanced braces around else statement
#1183: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1154:
+		} else

-:1352: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1352: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1323:
+
+

-:1753: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
#1753: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1724:
+				    S_IRUGO | S_IWUSR,

-:1930: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#1930: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1901:
+		debugfs_create_file("i915_panel_timings", S_IRUGO, root,

-:1932: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#1932: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1903:
+		debugfs_create_file("i915_psr_sink_status", S_IRUGO, root,

-:1939: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#1939: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1910:
+		debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,

-:1946: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#1946: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:1917:
+		debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,

-:2549: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#2549: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2017:
+		seq_printf(m, "\n");

-:2582: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2582: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2028:
+	seq_printf(m, "Isochronous Priority Control: %s\n",
+			yesno(dev_priv->ipc_enabled));

total: 0 errors, 16 warnings, 12 checks, 3951 lines checked