[Intel-gfx] [PATCH] drm/i915: Mark i915.reset as unsigned

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Feb 5 14:03:14 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> We have been using '-1' to mean the maximum i915.reset level in the
> belief that it was unsigned... This turns out to have been a grave
> error, and instead of setting the default reset mechanism in igt,
> we have been disabling reset!

Disabling engine reset?

-Mika

>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index cb16410c2ada..45323732f099 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -63,7 +63,7 @@ struct drm_printer;
>  	param(char *, dmc_firmware_path, NULL, 0400) \
>  	param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO), 0600) \
>  	param(int, edp_vswing, 0, 0400) \
> -	param(int, reset, 3, 0600) \
> +	param(unsigned int, reset, 3, 0600) \
>  	param(unsigned int, inject_probe_failure, 0, 0600) \
>  	param(int, fastboot, -1, 0600) \
>  	param(int, enable_dpcd_backlight, -1, 0600) \
> -- 
> 2.25.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list