[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client engine busyness (rev4)

Patchwork patchwork at emeril.freedesktop.org
Fri Feb 7 20:19:36 UTC 2020


== Series Details ==

Series: Per client engine busyness (rev4)
URL   : https://patchwork.freedesktop.org/series/70977/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f50257412ea0 drm/i915: Expose list of clients in sysfs
-:65: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#65: 
new file mode 100644

-:70: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#70: FILE: drivers/gpu/drm/i915/i915_drm_client.c:1:
+/*

-:71: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#71: FILE: drivers/gpu/drm/i915/i915_drm_client.c:2:
+ * SPDX-License-Identifier: MIT

-:228: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#228: FILE: drivers/gpu/drm/i915/i915_drm_client.h:1:
+/*

-:229: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#229: FILE: drivers/gpu/drm/i915/i915_drm_client.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 340 lines checked
45b83964a478 drm/i915: Update client name on context create
-:174: ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#174: FILE: drivers/gpu/drm/i915/i915_drm_client.c:171:
+struct client_update_free
+{

-:216: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#216: FILE: drivers/gpu/drm/i915/i915_drm_client.c:213:
+	if (!name) {
+		drm_notice(&i915->drm,

-:258: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#258: FILE: drivers/gpu/drm/i915/i915_drm_client.h:29:
+	struct mutex update_lock;

total: 1 errors, 1 warnings, 1 checks, 219 lines checked
3b55d5589621 drm/i915: Make GEM contexts track DRM clients
02d2f600b3e6 drm/i915: Track per-context engine busyness
c1b02b71e21c drm/i915: Track per drm client engine class busyness
209d107b652f drm/i915: Expose per-engine client busyness
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
     Render/3D/0   63.73% |███████████████████           |      3%      0%

-:96: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#96: FILE: drivers/gpu/drm/i915/i915_drm_client.c:78:
+static const char *uabi_class_names[] = {

total: 0 errors, 2 warnings, 0 checks, 172 lines checked



More information about the Intel-gfx mailing list