[Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

Chris Wilson chris at chris-wilson.co.uk
Mon Feb 10 13:45:06 UTC 2020


Quoting Andi Shyti (2020-02-10 13:40:39)
> "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*])
> 
> I agree, change the functions name from "debugfs_*" to
> "intel_gt_*" prefix.
> 
> [*] https://patchwork.freedesktop.org/patch/352553/#comment_651183
> 
> Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gt/debugfs_engines.c |  4 ++--
>  drivers/gpu/drm/i915/gt/debugfs_engines.h |  2 +-
>  drivers/gpu/drm/i915/gt/debugfs_gt.c      | 14 +++++++-------
>  drivers/gpu/drm/i915/gt/debugfs_gt.h      | 10 +++++-----
>  drivers/gpu/drm/i915/gt/debugfs_gt_pm.c   |  4 ++--
>  drivers/gpu/drm/i915/gt/debugfs_gt_pm.h   |  2 +-
>  drivers/gpu/drm/i915/gt/intel_gt.c        |  2 +-
>  7 files changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/debugfs_engines.c b/drivers/gpu/drm/i915/gt/debugfs_engines.c
> index 6a5e9ab20b94..2d4ab974ab67 100644
> --- a/drivers/gpu/drm/i915/gt/debugfs_engines.c
> +++ b/drivers/gpu/drm/i915/gt/debugfs_engines.c
> @@ -26,11 +26,11 @@ static int engines_show(struct seq_file *m, void *data)
>  }
>  DEFINE_GT_DEBUGFS_ATTRIBUTE(engines);
>  
> -void debugfs_engines_register(struct intel_gt *gt, struct dentry *root)
> +void engines_register_debugfs(struct intel_gt *gt, struct dentry *root)

Bad. If you are going to do this, intel_gt something. (At a push,
intel_engines, but maybe we shouldn't spread that too much as that
currently takes i915 to work on the uapi lists.)

But I don't really care, we can cross this bridge if debugfs feature
creeps beyond its current cave.
-Chris


More information about the Intel-gfx mailing list