[Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

Chris Wilson chris at chris-wilson.co.uk
Mon Feb 10 14:00:09 UTC 2020


Quoting Andi Shyti (2020-02-10 13:58:08)
> Hi Chris,
> 
> > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*])
> > > 
> > > I agree, change the functions name from "debugfs_*" to
> > > "intel_gt_*" prefix.
> > 
> > An alternate way of looking at it is that these are all dependent on
> > CONFIG_DEBUGFS. So are they not the debugfs interface?
> 
> this is a complete matter of taste, I might have a strong opinion
> if the concept of name prefix was something respected all over
> i915, but that's not always the case.

It's an object prefix; here I'd like to argue that it is the global
debugfs/ that is the 'owner' (or root?) for this interface.

> If Jani feels like enforcing the idea of the function name
> prefix, I basically agree with the style.
> 
> With "debugfs_*" I understand all those functions that handle the
> debugfs as framework.

Exactly.
-Chris


More information about the Intel-gfx mailing list