[Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Feb 11 13:00:19 UTC 2020


On 11/02/2020 10:37, Chris Wilson wrote:
> Quoting Andi Shyti (2020-02-11 00:42:55)
>> Hi Chris,
>>
>> On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote:
>>> The engine names are now stored inside the iterator and not as static
>>> strings. If we wish to use them later, we need to make a copy.
>>
>> But we are not using them later. Your patch just copies and frees
>> an array.
> 
> They are used inside an igt_info() in the child processes. Output at the
> moment is quite strange.

I also don't get this - child has a copy of everything how can it not work?

Regards,

Tvrtko




More information about the Intel-gfx mailing list