[Intel-gfx] [PATCH v2 0/6] 3 display pipes combination system support

[Anshuman Gupta]

On 2020-02-07 at 18:15:31 +0200, Ville Syrjälä wrote:
> On Fri, Feb 07, 2020 at 07:50:36PM +0530, Anshuman Gupta wrote:
> > Updated version after rebase and fixing few comments.
> > 
> > Anshuman Gupta (6):
> >   drm/i915: Iterate over pipe and skip the disabled one
> >   drm/i915: Remove (pipe == crtc->index) assumption
> >   drm/i915: Fix broken transcoder err state
> >   drm/i915: Fix wrongly populated plane possible_crtcs bit mask
> >   drm/i915: Get right max plane stride
> >   drm/i915: Add WARN_ON in intel_get_crtc_for_pipe()
> 
> Another broken thing I realized recently is due to my
> commit ee34801cc0e8 ("drm/i915: Prefer to use the pipe to index the ddb
> entries")
> 
> We either need to revert that or always pass s/num_pipes/I915_MAX_PIPES/
> to skl_ddb_allocation_overlaps() in skl_commit_modeset_enables().
> The latter may be nicer since I don't really want that silly 'i'
> usage back. Can you cook up a patch like that as well?
AFAIU entries[] may have holes inside it as its size is I915_MAX_PIPES,
though these holes are already initialized with zero and will not harm 
skl_ddb_allocation_overlaps, is it good a idea to avoid these hole
as ignore_index bit mask ?

Thanks ,
Anshuman Gupta.
> 
> > 
> >  drivers/gpu/drm/i915/display/intel_display.c  | 31 +++++++++++---
> >  drivers/gpu/drm/i915/display/intel_display.h  |  5 ++-
> >  .../drm/i915/display/intel_display_types.h    | 12 +++++-
> >  drivers/gpu/drm/i915/display/intel_sprite.c   |  5 +--
> >  drivers/gpu/drm/i915/i915_irq.c               | 40 ++++++++++++++-----
> >  5 files changed, 71 insertions(+), 22 deletions(-)
> > 
> > -- 
> > 2.24.0
> 
> -- 
> Ville Syrjälä
> Intel