[Intel-gfx] [PATCH v3 08/10] drm/i915/uc: Abort early on uc_init failure

Andi Shyti andi at etezian.org
Wed Feb 12 01:47:03 UTC 2020


Hi Daniele,

> +	if (intel_uc_uses_huc(uc)) {
> +		ret = intel_huc_init(huc);

are we ever going to call intel_huc_init() if
!intel_uc_uses_huc()? if not, why don't check intel_uc_uses_huc()
inside intel_huc_init()? just to avoid always the double "if".

Not a big deal though:

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Andi


More information about the Intel-gfx mailing list