[Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

Wed Feb 12 09:37:30 UTC 2020

An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200212/4f562a44/attachment-0001.htm>
-------------- next part --------------
Hi Takashi

Sorry to bother you again, during this period I do some experiment then issue may be fixed by my local patch, but I am not sure, however may I have your suggestion if you are available.
I put snd_hda_codec_read and snd_hda_codec_set_power_to_all ahead then add debug log in function haswell_verify_D0 I found my changes cause cvt_nid and nid could get "power state: 1" every single time after re-plug type-c cable then playing music, you can see flash_once_fixed_messages in details. But without my patch which nid gets "power state: 0" and external type-c monitor flashes once after playing music. Assume my finding is right, do we have chance to submit code to fix issue? Thanks.

With patch
2020-02-12T00:58:27.496016-08:00 ERR kernel: [   47.729823] @@@ cvt_nid power state: 1
2020-02-12T00:58:27.496024-08:00 ERR kernel: [   47.729883] @@@ nid power state: 1

Without patch
2020-02-12T00:55:36.795016-08:00 ERR kernel: [  125.047502] @@@ cvt_nid power state: 1
2020-02-12T00:55:36.795026-08:00 ERR kernel: [  125.047565] @@@ nid power state: 0

-----Original Message-----
From: Takashi Iwai <tiwai at suse.de> 
Sent: Wednesday, January 8, 2020 2:18 PM
To: Kao. Lucien (TPE) <Lucien_Kao at compal.com>
Cc: nathan.d.ciobanu at linux.intel.com; Cheng. AJ (TPE) <AJ_Cheng at compal.com>; intel-gfx at lists.freedesktop.org; alsa-devel at alsa-project.org; Wang. CindyXT (TPE) <CindyXT_Wang at compal.com>; Ye. Nelson (TPE) <Nelson_Ye at compal.com>; Yap. Shane (TPE) <Shane_Yap at compal.com>; Tseng. Evan (TPE) <Evan_Tseng at compal.com>
Subject: Re: [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

On Wed, 08 Jan 2020 04:07:17 +0100,
<Lucien_Kao at compal.com> wrote:
> 
> Hi Takashi
> 
> Is the attachment what you suspect? That merged to our kernel v4.19 already, have any suggestions? Thanks.

Then I have no concrete idea.  It might be some other changes in HDMI codec driver or it might be a fix in i915 graphics side, or even thunderbolt or whatever, too...

Takashi

> 
> -----Original Message-----
> From: Takashi Iwai <tiwai at suse.de>
> Sent: Wednesday, January 8, 2020 2:57 AM
> To: Nathan Ciobanu <nathan.d.ciobanu at linux.intel.com>
> Cc: Kao. Lucien (TPE) <Lucien_Kao at compal.com>; Cheng. AJ (TPE) 
> <AJ_Cheng at compal.com>; intel-gfx at lists.freedesktop.org; 
> alsa-devel at alsa-project.org; Wang. CindyXT (TPE) 
> <CindyXT_Wang at compal.com>; Ye. Nelson (TPE) <Nelson_Ye at compal.com>; 
> Yap. Shane (TPE) <Shane_Yap at compal.com>; Tseng. Evan (TPE) 
> <Evan_Tseng at compal.com>
> Subject: Re: [alsa-devel] USB Type-C monitor flashes once when play a 
> video file after unplug and re-plug the monitor
> 
> On Tue, 07 Jan 2020 18:24:57 +0100,
> Nathan Ciobanu wrote:
> > 
> > On Mon, Jan 06, 2020 at 08:08:04AM +0000, Lucien_Kao at compal.com wrote:
> > > Hi Takashi
> > > 
> > > We verified on Ubuntu 19.10 with kernel 5.4.0.0-050400-generic (please refer to attachment), the result is positive which symptom doesn't happen anymore once I played music or video sound output through Dell S2718D Type-C monitor. It seems had some fix in latest kernel.
> > 
> > Takashi, can you point to the patch series you suspect may have fixed this issue? 
> 
> The first suspect would be
> 2756d9143aa517b97961e85412882b8ce31371a6
>     ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips
> 
> Takashi
> 
> > 
> > Thanks,
> > Nathan
> > > 
> > > Thanks.
> > > 
> > > 
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai at suse.de>
> > > Sent: Friday, January 3, 2020 5:16 PM
> > > To: Cheng. AJ (TPE) <AJ_Cheng at compal.com>
> > > Cc: intel-gfx at lists.freedesktop.org; alsa-devel at alsa-project.org; 
> > > nathan.d.ciobanu at linux.intel.com; Wang. CindyXT (TPE) 
> > > <CindyXT_Wang at compal.com>; Ye. Nelson (TPE) 
> > > <Nelson_Ye at compal.com>; Yap. Shane (TPE) <Shane_Yap at compal.com>; 
> > > Kao. Lucien (TPE) <Lucien_Kao at compal.com>; Tseng. Evan (TPE) 
> > > <Evan_Tseng at compal.com>
> > > Subject: Re: [alsa-devel] USB Type-C monitor flashes once when 
> > > play a video file after unplug and re-plug the monitor
> > > 
> > > On Fri, 03 Jan 2020 02:57:03 +0100, <AJ_Cheng at compal.com> wrote:
> > > > 
> > > > Hi Sirs,
> > > >         Here is chromebook SW team from Compal.
> > > > As the mail title, we hit issue that the external monitor will flash once when play video after hot pluging.
> > > > We can reproduce not only on chromebook but also ubuntu 16.04.
> > > > There has higher failure rate with Dell Solomon dock and Dell S2718D monitor.
> > > > 
> > > > We found adding the delay in "sound/pci/hda/patch_hdmi.c " can 
> > > > fix this issue.(as the attachment) May need your help to review and advice. Thanks.
> > > > 
> > > > Here is the issue number in gitlab for more detail.
> > > > https://gitlab.freedesktop.org/drm/intel/issues/318
> > > 
> > > Could you check whether it still happens with the latest upstream kernel, at least 5.4.y, if it wasn't tested yet?
> > > 
> > > I don't want to put a long delay just because of random reason unless it's really mandatory.  I'm wondering whether the recent write-sync change improves the situation, so let's check the recent code.
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > > 
> > > > 
> > > > 
> > > > 
> > > > AJ Cheng
> > > > NID/NID1
> > > > e-mail: AJ_Cheng at compal.com<mailto:AJ_Cheng at compal.com>
> > > > Tel:  +886-2-8797-8599 ext. 17561 Mobile : +886-932827829 COMPAL 
> > > > Electronics, Inc.
> > > > 
> > > > [2 flash_once.diff <application/octet-stream (base64)>]
> > > > 
> > > > _______________________________________________
> > > > Alsa-devel mailing list
> > > > Alsa-devel at alsa-project.org
> > > > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> > 
> 
> ======================================================================
> ========
> =================================
> This message may contain information which is private, privileged or 
> confidential of Compal Electronics, Inc.
> If you are not the intended recipient of this message, please notify 
> the sender and destroy/delete the message.
> Any review, retransmission, dissemination or other use of, or taking 
> of any action in reliance upon this information, by persons or 
> entities other than the intended recipient is prohibited.
> ======================================================================
> ========
> =================================
> 
> 
> [1.2  <text/plain; us-ascii (base64)>]
> 
> [2 0001-UPSTREAM-ALSA-hda-Fix-intermittent-CORB-RIRB-stall-o.patch 
> <application/octet-stream (base64)>]
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flash_once_fixed_messages
Type: application/octet-stream
Size: 441200 bytes
Desc: flash_once_fixed_messages
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200212/4f562a44/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flash_once_present_messages
Type: application/octet-stream
Size: 33131 bytes
Desc: flash_once_present_messages
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200212/4f562a44/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flash_once.diff
Type: application/octet-stream
Size: 1457 bytes
Desc: flash_once.diff
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200212/4f562a44/attachment-0005.obj>