[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Proper dbuf global state

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 13 20:47:59 UTC 2020


== Series Details ==

Series: drm/i915: Proper dbuf global state
URL   : https://patchwork.freedesktop.org/series/73421/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
105574d3d6d9 drm/i915: Introduce proper dbuf state
-:179: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#179: FILE: drivers/gpu/drm/i915/display/intel_display.c:18491:
+	dev_priv->active_pipes = cdclk_state->active_pipes =

-:610: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#610: FILE: drivers/gpu/drm/i915/intel_pm.h:77:
+#define intel_atomic_get_old_dbuf_state(state) \
+	to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))

-:611: WARNING:LONG_LINE: line over 100 characters
#611: FILE: drivers/gpu/drm/i915/intel_pm.h:78:
+	to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))

-:612: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#612: FILE: drivers/gpu/drm/i915/intel_pm.h:79:
+#define intel_atomic_get_new_dbuf_state(state) \
+	to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))

-:613: WARNING:LONG_LINE: line over 100 characters
#613: FILE: drivers/gpu/drm/i915/intel_pm.h:80:
+	to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))

total: 0 errors, 2 warnings, 3 checks, 541 lines checked
8c6729a09771 drm/i915: Polish some dbuf debugs
f51308e472a5 drm/i915: Unify the low level dbuf code
23efcff9a67e drm/i915: Nuke skl_ddb_get_hw_state()
246e420dd654 drm/i915: Move the dbuf pre/post plane update
bc797241a9a7 drm/i915: Clean up dbuf debugs during .atomic_check()



More information about the Intel-gfx mailing list