[Intel-gfx] [PATCH 2/2] drm/i915: switch vlv_suspend to use intel uncore register accessors

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 13 23:38:59 UTC 2020


Quoting Jani Nikula (2020-02-12 14:40:58)
> Prefer intel_uncore_* over I915_READ, I915_WRITE, and POSTING_READ.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

A couple of older checkpatch errors that could be cleaned up (pure
whitespacing).

Both
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Half this code should be removed as we explicitly reset the registers on
resume. (And if we need to add a few special runtime-resume hooks, would
not be a bad thing). And the other half, probably should be removed with
a bit of extra work.
-Chris


More information about the Intel-gfx mailing list