[Intel-gfx] [PATCH v3 09/10] drm/i915/uc: consolidate firmware cleanup

[Daniele Ceraolo Spurio]

On 2/13/20 3:44 PM, John Harrison wrote:
> On 2/11/2020 16:31, Daniele Ceraolo Spurio wrote:
>> We are quite trigger happy in cleaning up the firmware blobs, as we do
>> so from several error/fini paths in GuC/HuC/uC code. We do have the
>> __uc_cleanup_firmwares cleanup function, which unwinds
>> __uc_fetch_firmwares and is already called both from the error path of
>> gem_init and from gem_driver_release, so let's stop cleaning up from
>> all the other paths.
>>
>> The fact that we're not cleaning the firmware immediately means that
>> we can't consider firmware availability as an indication of
>> initialization success. A "READY_TO_LOAD" status has been added to
> Is it not worth updating the commit message to use the name that is 
> actually in the code now?

D'oh! Missed this one.

Daniele

> 
> Otherwise:
> Reviewed-by: John Harrison <John.C.Harrison at Intel.com>
> 
>> indicate that the initialization was successful, to be used to
>> selectively load HuC only if HuC init has completed (HuC init failure
>> is not considered a fatal error).
>>
>> v2: s/ready_to_load/loadable (Michal), only run guc/huc_fini if the
>>      fw is in loadable state
>>
>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com> #v1
>> ---
>>   drivers/gpu/drm/i915/gt/uc/intel_guc.c   | 12 +++++-------
>>   drivers/gpu/drm/i915/gt/uc/intel_huc.c   |  5 +++--
>>   drivers/gpu/drm/i915/gt/uc/intel_uc.c    |  2 +-
>>   drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c |  7 +++++--
>>   drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 18 +++++++++++++++---
>>   5 files changed, 29 insertions(+), 15 deletions(-)
>>
>