[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support

Patchwork patchwork at emeril.freedesktop.org
Tue Feb 18 22:36:24 UTC 2020


== Series Details ==

Series: Refactor Gen11+ SAGV support
URL   : https://patchwork.freedesktop.org/series/73584/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1c72d442abeb drm/i915: Start passing latency as parameter
b0f9bed0c1be drm/i915: Introduce skl_plane_wm_level accessor.
f8c8b7d5f472 drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
also in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state

-:45: WARNING:LINE_SPACING: Missing a blank line after declarations
#45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:395:
+	struct intel_global_state *bw_state;
+	bw_state = intel_atomic_get_new_global_obj_state(state, &dev_priv->bw_obj);

total: 0 errors, 2 warnings, 0 checks, 49 lines checked
fe62c40aa234 drm/i915: Refactor intel_can_enable_sagv
-:77: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#77: 
      when using skl_plane_wm_level accessor, as we had previously for Gen11+

-:203: CHECK:LINE_SPACING: Please don't use multiple blank lines
#203: FILE: drivers/gpu/drm/i915/display/intel_global_state.h:87:
 
+

-:298: CHECK:LINE_SPACING: Please don't use multiple blank lines
#298: FILE: drivers/gpu/drm/i915/intel_pm.c:3812:
+
+

-:357: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'state->active_pipes == dev_priv->active_pipes'
#357: FILE: drivers/gpu/drm/i915/intel_pm.c:3871:
+	if ((state->active_pipes == dev_priv->active_pipes) &&
+	    (total_affected_planes == 0))

-:357: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'total_affected_planes == 0'
#357: FILE: drivers/gpu/drm/i915/intel_pm.c:3871:
+	if ((state->active_pipes == dev_priv->active_pipes) &&
+	    (total_affected_planes == 0))

-:456: WARNING:LINE_SPACING: Missing a blank line after declarations
#456: FILE: drivers/gpu/drm/i915/intel_pm.c:4002:
+		int active_pipe_bit = dev_priv->active_pipes & BIT(i);
+		if (active_pipe_bit) {

-:566: CHECK:LINE_SPACING: Please don't use multiple blank lines
#566: FILE: drivers/gpu/drm/i915/intel_pm.c:4810:
+
+

-:659: WARNING:LONG_LINE: line over 100 characters
#659: FILE: drivers/gpu/drm/i915/intel_pm.c:5883:
+					    old_wm->sagv_wm0.min_ddb_alloc : old_wm->wm[0].min_ddb_alloc;

-:662: WARNING:LONG_LINE: line over 100 characters
#662: FILE: drivers/gpu/drm/i915/intel_pm.c:5886:
+					    new_wm->sagv_wm0.min_ddb_alloc : new_wm->wm[0].min_ddb_alloc;

-:774: WARNING:LONG_LINE: line over 100 characters
#774: FILE: drivers/gpu/drm/i915/intel_pm.c:6125:
+						 &new_crtc_state->wm.skl.optimal.planes[plane_id])) {

total: 0 errors, 5 warnings, 5 checks, 702 lines checked
5c948ee6e68b drm/i915: Added required new PCode commands
d54a20f1dbff drm/i915: Restrict qgv points which don't have enough bandwidth.
ce7aae32b76b drm/i915: Enable SAGV support for Gen12



More information about the Intel-gfx mailing list