[Intel-gfx] [PATCH] drm/i915: Correctly terminate connector iteration

[Chris Wilson]

Quoting Chris Wilson (2020-02-21 15:46:22)
> Quoting Ville Syrjala (2020-02-21 15:43:10)
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > One should use drm_connector_list_iter_end() rather than
> > drm_connector_list_iter_begin() to terminate the connector
> > iteration.
> > 
> > Cc: Manasi Navare <manasi.d.navare at intel.com>
> > Cc: Uma Shankar <uma.shankar at intel.com>
> > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1278
> > Fixes: e24bcd34c1dd ("drm/i915/dp: Add all tiled and port sync conns to modeset")
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 0660b8c333ac..7e8280fc62ba 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -6622,7 +6622,7 @@ static int intel_modeset_tile_group(struct intel_atomic_state *state,
> >                 if (ret)
> >                         break;
> >         }
> > -       drm_connector_list_iter_begin(&dev_priv->drm, &conn_iter);
> > +       drm_connector_list_iter_end(&conn_iter);
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> How did this escape lockdep? I wonder.

lock_acquire_shared_recursive()

Because it's a read-lock.
-Chris