[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Feb 21 21:24:34 UTC 2020


== Series Details ==

Series: Refactor Gen11+ SAGV support (rev2)
URL   : https://patchwork.freedesktop.org/series/73703/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ba1e4cbe4558 drm/i915: Start passing latency as parameter
2712b33bd072 drm/i915: Introduce skl_plane_wm_level accessor.
535a61cedba3 drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
also in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state

-:45: WARNING:LINE_SPACING: Missing a blank line after declarations
#45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:395:
+	struct intel_global_state *bw_state;
+	bw_state = intel_atomic_get_new_global_obj_state(state, &dev_priv->bw_obj);

total: 0 errors, 2 warnings, 0 checks, 49 lines checked
236d09415710 drm/i915: Refactor intel_can_enable_sagv
-:77: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#77: 
      when using skl_plane_wm_level accessor, as we had previously for Gen11+

-:211: CHECK:LINE_SPACING: Please don't use multiple blank lines
#211: FILE: drivers/gpu/drm/i915/display/intel_global_state.h:87:
 
+

-:306: CHECK:LINE_SPACING: Please don't use multiple blank lines
#306: FILE: drivers/gpu/drm/i915/intel_pm.c:3812:
+
+

-:367: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'state->active_pipes == dev_priv->active_pipes'
#367: FILE: drivers/gpu/drm/i915/intel_pm.c:3873:
+	if ((state->active_pipes == dev_priv->active_pipes) &&
+	    (total_affected_planes == 0)) {

-:367: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'total_affected_planes == 0'
#367: FILE: drivers/gpu/drm/i915/intel_pm.c:3873:
+	if ((state->active_pipes == dev_priv->active_pipes) &&
+	    (total_affected_planes == 0)) {

-:413: WARNING:LINE_SPACING: Missing a blank line after declarations
#413: FILE: drivers/gpu/drm/i915/intel_pm.c:3919:
+		int active_pipe_bit = dev_priv->active_pipes & BIT(pipe);
+		if (active_pipe_bit) {

-:590: CHECK:LINE_SPACING: Please don't use multiple blank lines
#590: FILE: drivers/gpu/drm/i915/intel_pm.c:4820:
+
+

-:683: WARNING:LONG_LINE: line over 100 characters
#683: FILE: drivers/gpu/drm/i915/intel_pm.c:5893:
+					    old_wm->sagv_wm0.min_ddb_alloc : old_wm->wm[0].min_ddb_alloc;

-:686: WARNING:LONG_LINE: line over 100 characters
#686: FILE: drivers/gpu/drm/i915/intel_pm.c:5896:
+					    new_wm->sagv_wm0.min_ddb_alloc : new_wm->wm[0].min_ddb_alloc;

-:798: WARNING:LONG_LINE: line over 100 characters
#798: FILE: drivers/gpu/drm/i915/intel_pm.c:6135:
+						 &new_crtc_state->wm.skl.optimal.planes[plane_id])) {

total: 0 errors, 5 warnings, 5 checks, 718 lines checked
b2dfa073b7e0 drm/i915: Added required new PCode commands
53edf17a30f9 drm/i915: Restrict qgv points which don't have enough bandwidth.
c3ca73c4675f drm/i915: Enable SAGV support for Gen12



More information about the Intel-gfx mailing list