[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/24] drm/i915/gt: Check engine-is-awake on reset later
Patchwork
patchwork at emeril.freedesktop.org
Fri Feb 28 08:34:06 UTC 2020
== Series Details ==
Series: series starting with [01/24] drm/i915/gt: Check engine-is-awake on reset later
URL : https://patchwork.freedesktop.org/series/74064/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cf35476aba26 drm/i915/gt: Check engine-is-awake on reset later
2d9cb5454fb9 drm/i915: Skip barriers inside waits
eee7935e8b02 drm/i915/perf: Mark up the racy use of perf->exclusive_stream
2595bf7a20cf drm/i915/perf: Manually acquire engine-wakeref around use of kernel_context
970d94f49328 drm/i915/perf: Reintroduce wait on OA configuration completion
7f853a24cf81 drm/i915: Wrap i915_active in a simple kreffed struct
-:44: WARNING:LINE_SPACING: Missing a blank line after declarations
#44: FILE: drivers/gpu/drm/i915/i915_active.c:908:
+ struct auto_active *aa = container_of(ref, typeof(*aa), base);
+ kref_put(&aa->ref, auto_release);
total: 0 errors, 1 warnings, 0 checks, 66 lines checked
3866ade4b94e drm/i915: Extend i915_request_await_active to use all timelines
effe03fbfc33 drm/i915/perf: Schedule oa_config after modifying the contexts
ae1f01773370 drm/i915/gem: Consolidate ctx->engines[] release
79cc4030dfde drm/i915/gt: Prevent allocation on a banned context
2ad577382daf drm/i915/gem: Check that the context wasn't closed during setup
54c591ceb43f drm/i915/selftests: Disable heartbeat around manual pulse tests
10c7bfb49474 drm/i915/gt: Reset queue_priority_hint after wedging
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
<0> [574.303565] i915_sel-6278 2.... 481822445us : __i915_subtests: Running intel_execlists_live_selftests/live_error_interrupt
total: 0 errors, 1 warnings, 0 checks, 10 lines checked
d6a1ba655f2a drm/i915/gt: Pull marking vm as closed underneath the vm->mutex
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
References: 00de702c6c6f ("drm/i915: Check that the vma hasn't been closed before we insert it")
-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 00de702c6c6f ("drm/i915: Check that the vma hasn't been closed before we insert it")'
#12:
References: 00de702c6c6f ("drm/i915: Check that the vma hasn't been closed before we insert it")
total: 1 errors, 1 warnings, 0 checks, 26 lines checked
82df6afb9ed9 drm/i915: Protect i915_request_await_start from early waits
76c4b1fb4c01 drm/i915/selftests: Verify LRC isolation
-:449: WARNING:MEMORY_BARRIER: memory barrier without comment
#449: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5179:
+ wmb();
total: 0 errors, 1 warnings, 0 checks, 557 lines checked
1df5e762e382 drm/i915/selftests: Check recovery from corrupted LRC
4dfb2ecef5a8 drm/i915/selftests: Wait for the kernel context switch
8082262f522d drm/i915/selftests: Be a little more lenient for reset workers
03d66544ebb8 drm/i915/selftests: Add request throughput measurement to perf
-:90: WARNING:LINE_SPACING: Missing a blank line after declarations
#90: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1515:
+ struct intel_context *ce;
+ IGT_TIMEOUT(end_time);
-:157: WARNING:LINE_SPACING: Missing a blank line after declarations
#157: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1582:
+ struct intel_context *ce;
+ IGT_TIMEOUT(end_time);
-:213: WARNING:LINE_SPACING: Missing a blank line after declarations
#213: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1638:
+ struct drm_i915_private *i915 = arg;
+ static int (* const func[])(void *arg) = {
-:221: WARNING:LINE_SPACING: Missing a blank line after declarations
#221: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1646:
+ struct intel_engine_cs *engine;
+ int (* const *fn)(void *arg);
-:263: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#263: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1688:
+ yield(); /* start all threads before we kthread_stop() */
total: 0 errors, 5 warnings, 0 checks, 301 lines checked
9d4f288874ad drm/i915/gt: Declare when we enabled timeslicing
6dfe74ecc377 drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore
79f714f11f81 drm/i915/execlists: Check the sentinel is alone in the ELSP
750fb757725b drm/i915/execlists: Reduce preempt-to-busy roundtrip delay
More information about the Intel-gfx
mailing list