[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/perf: remove generated code

Patchwork patchwork at emeril.freedesktop.org
Sat Feb 29 13:02:35 UTC 2020


== Series Details ==

Series: series starting with [1/3] drm/i915/perf: remove generated code
URL   : https://patchwork.freedesktop.org/series/74107/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
882c81c4e09c drm/i915/perf: remove generated code
-:24: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '53f8f541ca', maybe rebased or not pulled?
#24: 
commit 53f8f541ca ("lib: Add i915_perf library"), previously this was

-:199: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#199: 
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 143 lines checked
db590d909d4c drm/i915/perf: reintroduce wait on OA configuration completion
-:29: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!rq"
#29: FILE: drivers/gpu/drm/i915/i915_perf.c:1388:
+	GEM_BUG_ON(rq == NULL);

-:46: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "stream->configure_request"
#46: FILE: drivers/gpu/drm/i915/i915_perf.c:1412:
+	GEM_BUG_ON(stream->configure_request != NULL);

-:66: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "stream->configure_request"
#66: FILE: drivers/gpu/drm/i915/i915_perf.c:2013:
+		GEM_BUG_ON(stream->configure_request != NULL);

-:123: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "stream->configure_request"
#123: FILE: drivers/gpu/drm/i915/i915_perf.c:2895:
+	GEM_BUG_ON(stream->configure_request != NULL);

total: 0 errors, 0 warnings, 4 checks, 123 lines checked
f1b1e775d6d9 drm/i915/perf: introduce global sseu pinning
-:239: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#239: FILE: drivers/gpu/drm/i915/i915_perf.c:2766:
+	user_engine = intel_engine_lookup_user(

-:252: CHECK:LINE_SPACING: Please don't use multiple blank lines
#252: FILE: drivers/gpu/drm/i915/i915_perf.c:2779:
+
+

total: 0 errors, 0 warnings, 2 checks, 328 lines checked



More information about the Intel-gfx mailing list