[Intel-gfx] [PATCH 2/2] drm/i915/gt: Allow temporary suspension of inflight requests

[kbuild test robot]

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip]
[cannot apply to v5.5-rc5 next-20200106]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Use-common-priotree-lists-for-virtual-engine/20200107-062647
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-g002-20200107 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu//drm/i915/gt/intel_lrc.c:2417:13: error: 'execlists_unhold' defined but not used [-Werror=unused-function]
    static void execlists_unhold(struct intel_engine_cs *engine,
                ^~~~~~~~~~~~~~~~
>> drivers/gpu//drm/i915/gt/intel_lrc.c:2385:13: error: 'execlists_hold' defined but not used [-Werror=unused-function]
    static void execlists_hold(struct intel_engine_cs *engine,
                ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/execlists_unhold +2417 drivers/gpu//drm/i915/gt/intel_lrc.c

  2384	
> 2385	static void execlists_hold(struct intel_engine_cs *engine,
  2386				   struct i915_request *rq)
  2387	{
  2388		spin_lock_irq(&engine->active.lock);
  2389		__execlists_hold(rq);
  2390		spin_unlock_irq(&engine->active.lock);
  2391	}
  2392	
  2393	static void __execlists_unhold(struct i915_request *rq)
  2394	{
  2395		struct i915_dependency *p;
  2396	
  2397		if (!i915_request_has_hold(rq))
  2398			return;
  2399	
  2400		i915_request_clear_hold(rq);
  2401		list_move_tail(&rq->sched.link,
  2402			       i915_sched_lookup_priolist(rq->engine, rq_prio(rq)));
  2403		set_bit(I915_FENCE_FLAG_PQUEUE, &rq->fence.flags);
  2404		RQ_TRACE(rq, "hold release\n");
  2405	
  2406		list_for_each_entry(p, &rq->sched.waiters_list, wait_link) {
  2407			struct i915_request *w =
  2408				container_of(p->waiter, typeof(*w), sched);
  2409	
  2410			if (w->engine != rq->engine)
  2411				continue;
  2412	
  2413			__execlists_unhold(w);
  2414		}
  2415	}
  2416	
> 2417	static void execlists_unhold(struct intel_engine_cs *engine,
  2418				     struct i915_request *rq)
  2419	{
  2420		spin_lock_irq(&engine->active.lock);
  2421		__execlists_unhold(rq);
  2422		if (rq_prio(rq) > engine->execlists.queue_priority_hint) {
  2423			engine->execlists.queue_priority_hint = rq_prio(rq);
  2424			tasklet_hi_schedule(&engine->execlists.tasklet);
  2425		}
  2426		spin_unlock_irq(&engine->active.lock);
  2427	}
  2428	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 34010 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200108/d80d790a/attachment-0001.gz>