[Intel-gfx] [PATCH] drm/i915/gt: Drop a defunct timeline assertion

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Jan 9 08:14:21 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> intel_timeline_enter() has been decoupled from intel_timeline_pin() and
> both enter/exit & pin/unpin are allowed [read expected] to run
> concurrently with one another. The assertion that they had better not is
> stale.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/940

Hmm I got page not found for this even tho other issues are shown :O

References to the decoupling part?

-Mika

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gt/intel_timeline.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
> index ee5dc4fbdeb9..87716529cd2f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_timeline.c
> +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
> @@ -348,7 +348,6 @@ void intel_timeline_enter(struct intel_timeline *tl)
>  	 * use atomic to manipulate tl->active_count.
>  	 */
>  	lockdep_assert_held(&tl->mutex);
> -	GEM_BUG_ON(!atomic_read(&tl->pin_count));
>  
>  	if (atomic_add_unless(&tl->active_count, 1, 0))
>  		return;
> -- 
> 2.25.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list