[Intel-gfx] [PATCH 12/14] drm/i915: Drop the shadow w/a batch buffer

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Jan 9 09:05:42 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> While this is technically the batch as executed by the HW (in part at
> least), it is confusing, and only used for a minority of gen.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index a35aad439281..796c9ce0c494 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1423,8 +1423,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
>  	vma = request_record_user(rq, vma, gfp);
>  	vma = capture_vma(vma, rq->ring->vma, "ring", gfp);
>  	vma = capture_vma(vma, rq->context->state, "HW context", gfp);
> -	if (HAS_BROKEN_CS_TLB(rq->i915))
> -		vma = capture_vma(vma, ee->engine->gt->scratch, "WA batch", gfp);
>  
>  	ee->rq_head = rq->head;
>  	ee->rq_post = rq->postfix;
> -- 
> 2.25.0.rc1


More information about the Intel-gfx mailing list