[Intel-gfx] [PATCH 03/14] drm/i915/gt: runtime-pm is no longer required for ce->ops->pin()

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Jan 10 14:37:41 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Now that we have moved the runtime-pm management out of
> intel_context_acctive_acquire, and that itself out of ce->ops->pin(),
> no

s/acctive/active

> explicit runtime pm wakeref is required in intel_context_pin().
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_context.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c
> index cac80d87b2bb..9796a54b4f47 100644
> --- a/drivers/gpu/drm/i915/gt/intel_context.c
> +++ b/drivers/gpu/drm/i915/gt/intel_context.c
> @@ -105,14 +105,11 @@ int __intel_context_do_pin(struct intel_context *ce)
>  		return -EINTR;
>  
>  	if (likely(!atomic_read(&ce->pin_count))) {
> -		intel_wakeref_t wakeref;
> -
>  		err = intel_context_active_acquire(ce);
>  		if (unlikely(err))
>  			goto err;
>  
> -		with_intel_runtime_pm(ce->engine->uncore->rpm, wakeref)
> -			err = ce->ops->pin(ce);
> +		err = ce->ops->pin(ce);
>  		if (unlikely(err))
>  			goto err_active;
>  
> -- 
> 2.25.0.rc1


More information about the Intel-gfx mailing list