[Intel-gfx] [PATCH v2] drm/i915/gt: Validate rotated vma bounds are within the object

Chris Wilson chris at chris-wilson.co.uk
Fri Jan 10 15:57:15 UTC 2020


Quoting Chris Wilson (2020-01-10 15:53:34)
> Quite understandably, we bug out when asked to find a page that doesn't
> belong to the object. However, we should report the error back to the
> user long before we attempt the out-of-bound access! In this case, it is
> insufficient validation on the rotated vma, with the simplest/cheapest
> point for us to insert a bound check when we are computing the rotated
> page lookups.
> 
> Similarly, it might be wise to see if we can validate the user input
> upon creating the rotated framebuffer.
Reminder to self, scratch this comment. They are, it's just a bug.
-Chris


More information about the Intel-gfx mailing list