[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 15 14:25:05 UTC 2020


== Series Details ==

Series: Misc GuC CT improvements - part II
URL   : https://patchwork.freedesktop.org/series/72071/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b07a956a95fe drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB
-:50: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tail >= size'
#50: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592:
+	if (unlikely(!IS_ALIGNED(head, 4) ||
+		     !IS_ALIGNED(tail, 4) ||
+		     !IS_ALIGNED(size, 4) ||
+		     (tail >= size) || (head >= size))) {

-:50: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'head >= size'
#50: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592:
+	if (unlikely(!IS_ALIGNED(head, 4) ||
+		     !IS_ALIGNED(tail, 4) ||
+		     !IS_ALIGNED(size, 4) ||
+		     (tail >= size) || (head >= size))) {

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
58e8d5866323 i915/drm/guc: Don't pass CTB while writing
649a099a7a62 i915/drm/guc: Don't pass CTB while reading
ce8ba4dabf49 drm/i915/guc: Switch to CT_ERROR in ct_read
17839d70f06c drm/i915/guc: Introduce CT_DEBUG



More information about the Intel-gfx mailing list