[Intel-gfx] [PATCH] drm/i915: Set num_qgv_points to zero if we can't query the actual points

Ville Syrjala ville.syrjala at linux.intel.com
Thu Jan 16 11:45:44 UTC 2020


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

If the pcode fails to give us the goods on any of the QGV points just
declare that we have none so that we'll properly ignore the bw limits.

Cc: Clinton A Taylor <clinton.a.taylor at intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_bw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index b228671d5a5d..eb9281e1831c 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -129,8 +129,10 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv,
 		struct intel_qgv_point *sp = &qi->points[i];
 
 		ret = icl_pcode_read_qgv_point_info(dev_priv, sp, i);
-		if (ret)
+		if (ret) {
+			qi->num_points = 0;
 			return ret;
+		}
 
 		DRM_DEBUG_KMS("QGV %d: DCLK=%d tRP=%d tRDPRE=%d tRAS=%d tRCD=%d tRC=%d\n",
 			      i, sp->dclk, sp->t_rp, sp->t_rdpre, sp->t_ras,
-- 
2.24.1



More information about the Intel-gfx mailing list