[Intel-gfx] [PATCH] drm/i915: Include the debugfs params header for its own definition

Jani Nikula jani.nikula at intel.com
Fri Jan 17 11:05:45 UTC 2020


On Fri, 17 Jan 2020, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> drivers/gpu/drm/i915/i915_debugfs_params.c:228:15: warning: symbol 'i915_debugfs_params' was not declared. Should it be static?
> drivers/gpu/drm/i915/i915_debugfs_params.c:228:16: error: no previous prototype for ‘i915_debugfs_params’ [-Werror=missing-prototypes]
>   228 | struct dentry *i915_debugfs_params(struct drm_i915_private *i915)
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula at intel.com>

/o\

Reviewed-by: Jani Nikula <jani.nikula at intel.com>
Fixes: c43c5a8818d4 ("drm/i915/params: add i915 parameters to debugfs")

> ---
>  drivers/gpu/drm/i915/i915_debugfs_params.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c
> index 12cbdbdf4d80..62b2c5f0495d 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs_params.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
> @@ -5,6 +5,7 @@
>  
>  #include <linux/kernel.h>
>  
> +#include "i915_debugfs_params.h"
>  #include "i915_drv.h"
>  #include "i915_params.h"

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list