[Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination

Andi Shyti andi.shyti at intel.com
Fri Jan 17 12:15:50 UTC 2020


Hi Zhang,

On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
> capture"), function 'i915_error_state_store' was defined and used with
> only one parameter.
> 
> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
> with two parameter.
> 
> This may lead compile error. This patch fix it.
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>

I've never been a fan of non human accounts, we had this discussion
already in a different mailing list. Could you please find a
different way of giving credit to your CI system?

> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5 at huawei.com>
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
> index 9109004956bd..41c1475e1500 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>  }
>  
>  static inline void
> -i915_error_state_store(struct drm_i915_private *i915,
> -		       struct i915_gpu_coredump *error)
> +i915_error_state_store(struct i915_gpu_coredump *error)

ouch! that's an oversight.

Thanks for your patch,

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Andi


More information about the Intel-gfx mailing list