[Intel-gfx] [PATCH xf86-video-intel] sna: Use correct struct sna in sna_mode_wakeup

Thomas Preston thomas.preston at codethink.co.uk
Wed Jan 22 13:10:47 UTC 2020


On 21/01/2020 14:11, Thomas Preston wrote:
> We're actually debugging this to close-in on *another* ZaphodHead+TearFree
> issue which appears on a 4.14 kernel (among other userland upgrades). At
> some point :0.0 head gets stuck between two buffers (current + shadow) and
> switches between the two causing a flicker or ghosting effect. It's
> possibly got something to do with these patches:
> 
> 	8bfac0f2 sna/dri2: Only force the TearFree/swcursor hack when using TearFree
> 	26f8ab54 sna: Restore local damage processing for TearFree/DRI2/swcursor early
> 	7cf67022 sna/dri2: Prevent the sw cursor from copyig to a buffer as we discard it
> 
> and it goes away when `-Dasync-swap=true` (APPLY_DAMAGE is 0) or we set:
> 
> 	 sna->ignore_copy_area = false; //sna->flags & SNA_TEAR_FREE;
> 

fyi the following patch fixes the flickering issue, so we just moved to
upstream + our struct sna fixup in sna_mode_wakeup

	95ea0564 sna: Rebalance prefer_blt to weight I915_TILING_Y higher


More information about the Intel-gfx mailing list