[Intel-gfx] [PATCH RESEND 6/6] drm/i915/pm: use intel de functions for forcewake register access

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 23 14:34:42 UTC 2020


Quoting Ville Syrjälä (2020-01-23 14:16:46)
> On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote:
> > Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and
> > switch to using intel_de_read_fw() and intel_de_write_fw(),
> > respectively.
> > 
> > No functional changes.
> > 
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> 
> Only a few oddities spotted. Overall series lgtm

Concurred, checkpatch is going to have some very stern words regarding
some of those lines!

> For all
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

+1
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list