[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Introduce struct drm_device based WARN* and use them in i915 (rev3)

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 23 19:57:42 UTC 2020


== Series Details ==

Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev3)
URL   : https://patchwork.freedesktop.org/series/72035/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ab441b2f141b drm/i915/display: Make WARN* drm specific where drm_device ptr is available
-:226: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#226: FILE: drivers/gpu/drm/i915/display/intel_display.c:10514:
+		drm_WARN_ON(dev, !pll->info->funcs->get_hw_state(dev_priv, pll,
 						&pipe_config->dpll_hw_state));

total: 0 errors, 0 warnings, 1 checks, 390 lines checked
f0a3afb9ae23 drm/i915/display: Make WARN* drm specific where drm_priv ptr is available
-:1247: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1247: FILE: drivers/gpu/drm/i915/display/intel_display.c:15207:
+		drm_WARN_ON(&dev_priv->drm,
+		    skl_ddb_allocation_overlaps(&new_crtc_state->wm.skl.ddb,

-:1258: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1258: FILE: drivers/gpu/drm/i915/display/intel_display.c:15243:
+		drm_WARN_ON(&dev_priv->drm,
+			skl_ddb_allocation_overlaps(&new_crtc_state->wm.skl.ddb,

-:1548: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1548: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:1067:
+	drm_WARN_ON(&dev_priv->drm,
+	    intel_cdclk_needs_modeset(&dev_priv->cdclk.hw, &cdclk_state));

-:2052: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2052: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:107:
+	if (drm_WARN_ON(&dev_priv->drm, pll < dev_priv->shared_dplls ||
+		pll > &dev_priv->shared_dplls[dev_priv->num_shared_dpll]))

-:2071: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll"
#2071: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:144:
+	if (drm_WARN_ON(&dev_priv->drm, pll == NULL))

-:2089: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll"
#2089: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:173:
+	if (drm_WARN_ON(&dev_priv->drm, pll == NULL))

-:2917: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2917: FILE: drivers/gpu/drm/i915/display/intel_tc.c:414:
+	drm_WARN_ON(&i915->drm, intel_display_power_is_enabled(i915,
+					intel_aux_power_domain(dig_port)));

total: 0 errors, 0 warnings, 7 checks, 2502 lines checked
a4e641c96669 drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available
ee7e674f9214 drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available
-:296: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#296: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1373:
+		drm_WARN_ONCE(&i915->drm, 1,
+				"VM(%d): iGVT-g doesn't support GuC\n",

-:310: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#310: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1389:
+		drm_WARN(&i915->drm, 1,
+				"VM(%d): Use physical address for TRTT!\n",

total: 0 errors, 0 warnings, 2 checks, 519 lines checked



More information about the Intel-gfx mailing list