[Intel-gfx] [RFC 00/33] drm/i915/display: mass conversion to intel_de_*() register accessors

Jani Nikula jani.nikula at intel.com
Fri Jan 24 13:25:21 UTC 2020


Hey all,

So I sent [1] to convert some forcewake register accessors... but what if we
just ripped off the bandage once and for all? It's going to hurt, a lot, but
we'd get it done.

This completely rids us of the "dev_priv" dependency in display/.

All the patches here are per-file and independent of each other. We could also
pick and apply the ones that are least likely to conflict.

Opinions?


BR,
Jani.


PS. I didn't bother looking at the checkpatch warnings this may generate at this
point. I just used the --linux-spacing option for spatch, and closed my eyes. I
completely scripted the generation of the series, apart from just a couple of
build fixes.


Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>

[1] https://patchwork.freedesktop.org/series/72476/


Jani Nikula (33):
  drm/i915/icl_dsi: use intel_de_*() functions for register access
  drm/i915/audio: use intel_de_*() functions for register access
  drm/i915/cdclk: use intel_de_*() functions for register access
  drm/i915/color: use intel_de_*() functions for register access
  drm/i915/combo_phy: use intel_de_*() functions for register access
  drm/i915/crt: use intel_de_*() functions for register access
  drm/i915/ddi: use intel_de_*() functions for register access
  drm/i915/display: use intel_de_*() functions for register access
  drm/i915/display_power: use intel_de_*() functions for register access
  drm/i915/dp: use intel_de_*() functions for register access
  drm/i915/dpio_phy: use intel_de_*() functions for register access
  drm/i915/dpll_mgr: use intel_de_*() functions for register access
  drm/i915/dp_mst: use intel_de_*() functions for register access
  drm/i915/dsb: use intel_de_*() functions for register access
  drm/i915/dvo: use intel_de_*() functions for register access
  drm/i915/fbc: use intel_de_*() functions for register access
  drm/i915/fifo_underrun: use intel_de_*() functions for register access
  drm/i915/gmbus: use intel_de_*() functions for register access
  drm/i915/hdcp: use intel_de_*() functions for register access
  drm/i915/hdmi: use intel_de_*() functions for register access
  drm/i915/lpe_audio: use intel_de_*() functions for register access
  drm/i915/lvds: use intel_de_*() functions for register access
  drm/i915/overlay: use intel_de_*() functions for register access
  drm/i915/panel: use intel_de_*() functions for register access
  drm/i915/pipe_crc: use intel_de_*() functions for register access
  drm/i915/psr: use intel_de_*() functions for register access
  drm/i915/sdvo: use intel_de_*() functions for register access
  drm/i915/sprite: use intel_de_*() functions for register access
  drm/i915/tv: use intel_de_*() functions for register access
  drm/i915/vdsc: use intel_de_*() functions for register access
  drm/i915/vga: use intel_de_*() functions for register access
  drm/i915/vlv_dsi: use intel_de_*() functions for register access
  drm/i915/vlv_dsi_pll: use intel_de_*() functions for register access

 drivers/gpu/drm/i915/display/icl_dsi.c        |  271 ++--
 drivers/gpu/drm/i915/display/intel_audio.c    |  112 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  133 +-
 drivers/gpu/drm/i915/display/intel_color.c    |  204 +--
 .../gpu/drm/i915/display/intel_combo_phy.c    |   66 +-
 drivers/gpu/drm/i915/display/intel_crt.c      |   51 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  474 +++----
 drivers/gpu/drm/i915/display/intel_display.c  | 1171 +++++++++--------
 .../drm/i915/display/intel_display_power.c    |  294 +++--
 drivers/gpu/drm/i915/display/intel_dp.c       |  234 ++--
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   11 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |   77 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  388 +++---
 drivers/gpu/drm/i915/display/intel_dsb.c      |   24 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |   34 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      |  106 +-
 .../drm/i915/display/intel_fifo_underrun.c    |   37 +-
 drivers/gpu/drm/i915/display/intel_gmbus.c    |   74 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |  142 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  258 ++--
 .../gpu/drm/i915/display/intel_lpe_audio.c    |   14 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |   57 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |   45 +-
 drivers/gpu/drm/i915/display/intel_panel.c    |  255 ++--
 drivers/gpu/drm/i915/display/intel_pipe_crc.c |   20 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   70 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   30 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  320 +++--
 drivers/gpu/drm/i915/display/intel_tv.c       |  138 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c     |  413 +++---
 drivers/gpu/drm/i915/display/intel_vga.c      |    7 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  345 ++---
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c    |   49 +-
 33 files changed, 3158 insertions(+), 2766 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list