[Intel-gfx] [PATCH] drm/i915: Add missing HDMI audio pixel clocks for gen12

Kai Vehmanen kai.vehmanen at linux.intel.com
Mon Jan 27 17:01:23 UTC 2020


Hi,

On Mon, 27 Jan 2020, Ville Syrjälä wrote:

> On Mon, Jan 27, 2020 at 01:39:09PM +0200, Kai Vehmanen wrote:
> > Gen12 hardware supports HDMI audio pixel clocks of 296.7/297Mhz
> > and 593.4/594Mhz. Add the missing rates and add logic to ignore
> > them if running on older hardware.
[...]
> >  	for (i = 0; i < ARRAY_SIZE(hdmi_audio_clock); i++) {
> > +		if (INTEL_GEN(dev_priv) < 12 &&
> > +		    hdmi_audio_clock[i].clock > 148500) {
> 
> Might be cleaner to do the check after the loop.

hmm, you are right. I'll wait for the CI results to come in and if nothing 
else found, I'll post V2 with the check moved outside the loop.

Thanks for the review Ville!

Br, Kai


More information about the Intel-gfx mailing list