[Intel-gfx] [PATCH v2 09/11] drm/i915: Turn intel_digital_port_connected() in a vfunc

[Jani Nikula]

On Tue, 21 Jan 2020, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
> index 3da166054788..cf0df6f18734 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp.h
> @@ -116,6 +116,12 @@ void intel_dp_vsc_enable(struct intel_dp *intel_dp,
>  void intel_dp_hdr_metadata_enable(struct intel_dp *intel_dp,
>  				  const struct intel_crtc_state *crtc_state,
>  				  const struct drm_connector_state *conn_state);
> +bool cpt_digital_port_connected(struct intel_encoder *encoder);
> +bool spt_digital_port_connected(struct intel_encoder *encoder);
> +bool ivb_digital_port_connected(struct intel_encoder *encoder);
> +bool bdw_digital_port_connected(struct intel_encoder *encoder);
> +bool bxt_digital_port_connected(struct intel_encoder *encoder);
> +bool icp_digital_port_connected(struct intel_encoder *encoder);

Please find a way to not expose a plethora of platform specific
functions from files. I want to take things to the completely opposite
direction.

Other than that, I like using the vfuncs.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center