[Intel-gfx] [PATCH 1/4] drm: Complain if drivers still use the ->load callback

[Thomas Zimmermann]

Hi

Am 28.01.20 um 11:45 schrieb Daniel Vetter:
> Kinda time to get this sorted. The locking around this really is not
> nice.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  drivers/gpu/drm/drm_drv.c | 6 ++++++
>  include/drm/drm_drv.h     | 3 +++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 7c18a980cd4b..8deff75b484c 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -948,6 +948,12 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
>  
>  	mutex_lock(&drm_global_mutex);
>  
> +	if (dev->driver->load) {
> +		if (!drm_core_check_feature(dev, DRIVER_LEGACY))
> +			DRM_INFO("drm driver %s is using deprecated ->load callback\n",
> +				 dev->driver->name);
> +	}
> +
>  	ret = drm_minor_register(dev, DRM_MINOR_RENDER);
>  	if (ret)
>  		goto err_minors;
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 77685ed7aa65..77bc63de0a91 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -173,6 +173,9 @@ struct drm_driver {
>  	 *
>  	 * This is deprecated, do not use!
>  	 *
> +	 * FIXME: A few non-DRIVER_LEGACY drivers still use this, and should be
> +	 * converted.
> +	 *

I recently converted several of them. The status here is that only
radeon and amdgpu still use load. I've only not been able to convert
them because they do some debugfs registering that relies on the device
being registered early. I've not had time to convert the code.

On the patch:

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>


>  	 * Returns:
>  	 *
>  	 * Zero on success, non-zero value on failure.
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200128/f1023e23/attachment.sig>