[Intel-gfx] [PATCH 1/2] drm/i915/gem: initial conversion to new logging macros using coccinelle

[Tvrtko Ursulin]

On 28/01/2020 13:48, Jani Nikula wrote:
> On Tue, 28 Jan 2020, Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com> wrote:
>>> -DRM_DEBUG(
>>> +drm_dbg(&T->drm,
>>
>> This changes DRM_UT_CORE to DRM_UT_DRIVER so our typical drm.debug=0xe
>> becomes much more spammy.
> 
> This is what I've instructed Wambui to do in i915. It's my mistake that
> I haven't requested this to be pointed out in the commit message.
> 
> DRM_DEBUG() and DRM_DEBUG_DRIVER() have been conflated over the
> years. The former is supposed to be for drm core code only, but drivers
> are littered with it. I'm hoping drivers are less likely to use the new
> drm_dbg_core() which maps to DRM_DEBUG(). The shorter drm_dbg() is the
> new DRM_DEBUG_DRIVER().
> 
> If you think drm.debug=0xe is too spammy now, the fix is not to abuse
> DRM_UT_CORE as a spare category.

For i915 negative impact (in terms of amount of new logging produced) is 
probably limited to CI runs. Maybe developer testing to a lesser extent. 
I think wait and see approach will be okay.

Regards,

Tvrtko