[Intel-gfx] [PATCH 5/5] drm/i915/gt: Split logical ring context manipulation into intel_lrc.c

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Tue Jan 28 23:50:27 UTC 2020



On 1/28/20 12:43 PM, Chris Wilson wrote:
> Extract the core functions for setting up the machine dependent logical
> ring context to intel_lrc.c. This will be shared by all submission
> backends that utilise logical ring contexts.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Moved code matches and as mentioned before I like the split.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

One nit:

<snip>

> +
> +int gen9_emit_flush_rcs(struct i915_request *request, u32 mode)

I've would've done the gen8/gen9 split in another patch to keep this one 
to a straight move.

Daniele



More information about the Intel-gfx mailing list