[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/execlist: Mark up racy read of execlists->pending[0]

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 29 02:10:00 UTC 2020


== Series Details ==

Series: series starting with [1/5] drm/i915/execlist: Mark up racy read of execlists->pending[0]
URL   : https://patchwork.freedesktop.org/series/72690/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
82aa4207ae44 drm/i915/execlist: Mark up racy read of execlists->pending[0]
e92382208498 drm/i915/gt: Hook up CS_MASTER_ERROR_INTERRUPT
52306730ac69 drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore
-:146: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#146: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1703:
+{
+

total: 0 errors, 0 warnings, 1 checks, 156 lines checked
90d22f43a723 drm/i915/gt: Rename lrc.c to execlists_submission.c
-:40: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
rename from drivers/gpu/drm/i915/gt/intel_lrc.c

total: 0 errors, 1 warnings, 0 checks, 20 lines checked
b5b64099ef97 drm/i915/gt: Split logical ring context manipulation into intel_lrc.c
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

-:756: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#756: FILE: drivers/gpu/drm/i915/gt/intel_engine_workaround_bb.c:304:
+	batch = batch_ptr = kmap_atomic(page);

-:2673: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'count' - possible side-effects?
#2673: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:132:
+#define LRI(count, flags) ((flags) << 6 | (count) | BUILD_BUG_ON_ZERO(count >= BIT(6)))

-:2675: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#2675: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:134:
+#define REG(x) (((x) >> 2) | BUILD_BUG_ON_ZERO(x >= 0x200))

-:2676: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2676: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:135:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:2676: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#2676: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:135:
+#define REG16(x) \
+	(((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
+	(((x) >> 2) & 0x7f)

-:2679: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2679: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:138:
+#define END(x) 0, (x)

total: 2 errors, 1 warnings, 4 checks, 4001 lines checked



More information about the Intel-gfx mailing list