[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: extract engine WA programming to common resume function

[Ville Syrjälä]

On Thu, Jan 30, 2020 at 01:37:49PM +0000, Chris Wilson wrote:
> Quoting Patchwork (2020-01-30 06:49:28)
> > #### Possible regressions ####
> > 
> >   * igt at i915_selftest@live_active:
> >     - fi-bwr-2160:        [PASS][1] -> [DMESG-WARN][2] +12 similar issues
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7840/fi-bwr-2160/igt@i915_selftest@live_active.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16327/fi-bwr-2160/igt@i915_selftest@live_active.html
> 
> Well it works on Crestline. Broadwater snafu?

Does the w/a thing actually work correctly for masked registers?
It look to use rmw even for masked registers and IIRC some masked
registers return 0xffff for the mask when read. I lost track of the
values and masks being passed around before I got down that deep so
can't immediatly see if the code is guaranteed to set only the
expected mask bit(s) for the write.

-- 
Ville Syrjälä
Intel