[Intel-gfx] [PATCH] drm/i915: Reboot CI if we get wedged during driver init
Chris Wilson
chris at chris-wilson.co.uk
Wed Jul 1 15:17:57 UTC 2020
Quoting Michał Winiarski (2020-07-01 16:07:21)
> From: Michał Winiarski <michal.winiarski at intel.com>
>
> Getting wedged device on driver init is pretty much unrecoverable.
> Since we're running verious scenarios that may potentially hit this in
> CI (module reload / selftests / hotunplug), and if it happens, it means
> that we can't trust any subsequent CI results, we should just apply the
> taint to let the CI know that it should reboot (CI checks taint between
> test runs).
>
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala at intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index 0156f1f5c736..d27e8bb7d550 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -1360,6 +1360,8 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt)
> I915_WEDGED_ON_INIT);
> intel_gt_set_wedged(gt);
> set_bit(I915_WEDGED_ON_INIT, >->reset.flags);
> +
Ah, we don't say around here that this WEDGED_ON_INIT is non-recoverable,
could you please add a comment to that effect?
> + add_taint_for_CI(TAINT_WARN);
> }
>
> void intel_gt_init_reset(struct intel_gt *gt)
> --
> 2.27.0
>
More information about the Intel-gfx
mailing list