[Intel-gfx] [PATCH v2 2/6] drm/i915/display: fix comment on skl straps

[Lucas De Marchi]

On Tue, Jun 30, 2020 at 06:55:38PM +0300, Jani Nikula wrote:
>On Wed, 24 Jun 2020, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>> We are not checking for specific SKUs and feedback from HW team is that
>> it may not work since it was supposed to be fixed by the same time
>> straps stopped to be used. So, just update comment.
>>
>> v2: Instead of removing the check, just update the comment since
>> feedback from HW team was that it actually may not work
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
>Acked-by: Jani Nikula <jani.nikula at intel.com>

is an ack  sufficient for merging a comment-only change?

Lucas De Marchi

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index 49772c82a299..effd6b65f270 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -16863,8 +16863,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>>
>>  		/*
>>  		 * Haswell uses DDI functions to detect digital outputs.
>> -		 * On SKL pre-D0 the strap isn't connected, so we assume
>> -		 * it's there.
>> +		 * On SKL pre-D0 the strap isn't connected. Later SKUs may or
>> +		 * may not have it - it was supposed to be fixed by the same
>> +		 * time we stopped using straps. Assume it's there.
>>  		 */
>>  		found = intel_de_read(dev_priv, DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
>>  		/* WaIgnoreDDIAStrap: skl */
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center