[Intel-gfx] [PATCH] drm/i915: Kill context before taking ctx->mutex

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Thu Jul 2 13:26:17 UTC 2020


Op 30-06-2020 om 16:16 schreef Tvrtko Ursulin:
>
> On 24/06/2020 12:05, Maarten Lankhorst wrote:
>> Killing context before taking ctx->mutex fixes a hang in
>> gem_ctx_persistence.close-replace-race, where lut_close
>> takes obj->resv.lock which is already held by execbuf,
>> causing a stalling indefinitely.
>
> If this is the consequence of inverting the locking order I think you need to move the fix earlier in the series, to precede the patch which creates the inversion. Otherwise AFAICT the re-order of kill_context vs lut_close seems fine. 

Yeah, it was just a bugfix I found when looking at the code, if you review it I can push it now so I don't have to resend.  :)

~Maarten



More information about the Intel-gfx mailing list