[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move some device capabilities under intel_gt (rev4)

Patchwork patchwork at emeril.freedesktop.org
Wed Jul 8 15:50:06 UTC 2020


== Series Details ==

Series: Move some device capabilities under intel_gt (rev4)
URL   : https://patchwork.freedesktop.org/series/78829/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
81adaf361708 drm/i915: Convert device_info to uncore/de_read
e45d8bbcd7f5 drm/i915: Use the gt in HAS_ENGINE
5e3310bf1e2a drm/i915: Move engine-related mmio init to engines_init_mmio
2c61035b8c47 drm/i915: Move the engine mask to intel_gt_info
d5805b164862 drm/i915: Introduce gt_init_mmio
24805dc1308d drm/i915/sseu: Move sseu detection and dump to intel_sseu
-:285: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#285: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:311:
+	 * across subslices.
+	*/

-:294: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#294: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:320:
+	 * more than one EU pair per subslice.
+	*/

-:320: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#320: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:346:
+	 * to each of the enabled slices.
+	*/

-:328: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#328: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:354:
+	 * count the total enabled EU.
+	*/

-:370: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#370: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:396:
+	 * distribution.
+	*/

-:382: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#382: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:408:
+	 * pair per subslice.
+	*/

-:506: WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#506: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:532:
+		/* fall through */

-:526: WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#526: FILE: drivers/gpu/drm/i915/gt/intel_sseu.c:552:
+		/* fall through */

total: 0 errors, 8 warnings, 0 checks, 1259 lines checked
aedcca102ac4 drm/i915/sseu: Move sseu_info under gt_info
459b33e50ba5 drm/i915: gt-fy sseu debugfs
-:121: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#121: FILE: drivers/gpu/drm/i915/i915_debugfs.c:1698:
+		eu_reg[2*s] = intel_uncore_read(uncore, GEN9_SS01_EU_PGCTL_ACK(s));
 		        ^

-:122: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#122: FILE: drivers/gpu/drm/i915/i915_debugfs.c:1699:
+		eu_reg[2*s + 1] = intel_uncore_read(uncore, GEN9_SS23_EU_PGCTL_ACK(s));
 		        ^

total: 0 errors, 0 warnings, 2 checks, 188 lines checked
c3278f5361ee drm/i915: Move sseu debugfs under gt/
-:50: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

-:178: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#178: FILE: drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c:124:
+		eu_reg[2*s] = intel_uncore_read(uncore, GEN9_SS01_EU_PGCTL_ACK(s));
 		        ^

-:179: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#179: FILE: drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c:125:
+		eu_reg[2*s + 1] = intel_uncore_read(uncore, GEN9_SS23_EU_PGCTL_ACK(s));
 		        ^

-:216: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#216: FILE: drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c:162:
+			eu_cnt = 2 * hweight32(eu_reg[2*s + ss/2] &
 			                               ^

-:216: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#216: FILE: drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c:162:
+			eu_cnt = 2 * hweight32(eu_reg[2*s + ss/2] &
 			                                      ^

-:217: CHECK:SPACING: spaces preferred around that '%' (ctx:VxV)
#217: FILE: drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c:163:
+					       eu_mask[ss%2]);
 					                 ^

total: 0 errors, 1 warnings, 5 checks, 637 lines checked



More information about the Intel-gfx mailing list