[Intel-gfx] [PATCH 6/7] drm/i915: Switch to object allocations for page directories

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 8 18:47:58 UTC 2020


Quoting Matthew Auld (2020-07-08 19:32:26)
> On Wed, 8 Jul 2020 at 14:48, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> > index 8291ede6902c..9fb06fcc8f8f 100644
> > --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> > +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> > @@ -393,7 +393,7 @@ static int igt_mock_exhaust_device_supported_pages(void *arg)
> >          */
> >
> >         for (i = 1; i < BIT(ARRAY_SIZE(page_sizes)); i++) {
> > -               unsigned int combination = 0;
> > +               unsigned int combination = SZ_4K;
> 
> Just an unrelated change?

As we try to allocate 4K PD objects to bind the huge page, it fails an
assert if we exclude SZ_4K from the list of supported page sizes from
the device.

I leave it to the reader to work out how we should tie everything
together for for variable pd sizes.
-Chris


More information about the Intel-gfx mailing list