[Intel-gfx] [bug report] drm/i915: Move the engine mask to intel_gt_info

dan.carpenter at oracle.com dan.carpenter at oracle.com
Fri Jul 10 14:11:47 UTC 2020


Hello Daniele Ceraolo Spurio,

This is a semi-automatic email about new static checker warnings.

The patch 792592e72aba: "drm/i915: Move the engine mask to
intel_gt_info" from Jul 7, 2020, leads to the following Smatch
complaint:

    drivers/gpu/drm/i915/i915_gpu_error.c:801 __err_print_to_sgl()
    error: we previously assumed 'error->gt' could be null (see line 792)

drivers/gpu/drm/i915/i915_gpu_error.c
   791	
   792		if (error->gt)
                    ^^^^^^^^^
Existing code checks for NULL.

   793			err_print_gt(m, error->gt);
   794	
   795		if (error->overlay)
   796			intel_overlay_print_error_state(m, error->overlay);
   797	
   798		if (error->display)
   799			intel_display_print_error_state(m, error->display);
   800	
   801		err_print_capabilities(m, error);
                                          ^^^^^
Unchecked dereference inside function call.

   802		err_print_params(m, &error->params);
   803	}

regards,
dan carpenter


More information about the Intel-gfx mailing list