[Intel-gfx] [PATCH 06/66] drm/i915: Export a preallocate variant of i915_active_acquire()

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Jul 17 13:06:59 UTC 2020


On 17/07/2020 13:45, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-07-17 13:21:54)
>>
>> On 15/07/2020 12:50, Chris Wilson wrote:
>>> Sometimes we have to be very careful not to allocate underneath a mutex
>>> (or spinlock) and yet still want to track activity. Enter
>>> i915_active_acquire_for_context(). This raises the activity counter on
>>> i915_active prior to use and ensures that the fence-tree contains a slot
>>> for the context.
>>
>> Changelog?
> 
> "Time spent with perf trying to reduce holdtime of certain mutexes we
> will introduce, in particular focusing on reducing the number of atomics
> required for typical i915_active lookups"

Why not, then I would had at least known nothing from my previous round 
feedback so easier review.

Regards,

Tvrtko


More information about the Intel-gfx mailing list