[Intel-gfx] [PATCH] drm/i915: Remove gen check before calling intel_rps_boost

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Jul 23 08:12:36 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> It's been a while since gen6_rps_boost() [that only worked on gen6+] was
> replaced by intel_rps_boost() that understood itself when rps was
> active. Since the intel_rps_boost() is gen-agnostic, just call it.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_request.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 679a915e9a63..e48daeef6882 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -1823,11 +1823,8 @@ long i915_request_wait(struct i915_request *rq,
>  	 * but at a cost of spending more power processing the workload
>  	 * (bad for battery).
>  	 */
> -	if (flags & I915_WAIT_PRIORITY) {
> -		if (!i915_request_started(rq) &&
> -		    INTEL_GEN(rq->engine->i915) >= 6)
> -			intel_rps_boost(rq);
> -	}
> +	if (flags & I915_WAIT_PRIORITY && !i915_request_started(rq))
> +		intel_rps_boost(rq);
>  
>  	wait.tsk = current;
>  	if (dma_fence_add_callback(&rq->fence, &wait.cb, request_wait_wake))
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list