[Intel-gfx] [PATCH 11/66] drm/i915: Preallocate stashes for vma page-directories

Thomas Hellström (Intel) thomas_os at shipmail.org
Mon Jul 27 09:24:24 UTC 2020


Hi, Chris,

It appears to me like this series is doing a lot of different things:

- Various optimizations
- Locking rework
- Adding schedulers
- Other misc fixes

Could you please separate out as much as possible the locking rework 
prerequisites in one series with cover letter, and most importantly the 
major part of the locking rework (only) with a more elaborate cover 
letter discussing, if not trivial, how each patch fits in and on design 
and future directions, Questions that I have stumbled on so far (being a 
new-to-the-driver reviewer):

- When are memory allocations disallowed? If we need to pre-allocate in 
execbuf, when? why?
- When is the request dma-fence published?
- Do we need to keep cpu asynchronous execbuf tasks after this? why?
- What about userptr pinning ending up in the dma_fence critical path?

And then move anything non-related to separate series?

Thanks,

Thomas




More information about the Intel-gfx mailing list