[Intel-gfx] [v2] drm/i915/display/fbc: Disable fbc by default on TGL
Shankar, Uma
uma.shankar at intel.com
Tue Jul 28 08:21:26 UTC 2020
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Sent: Thursday, July 16, 2020 8:15 PM
> To: Shankar, Uma <uma.shankar at intel.com>
> Cc: intel-gfx at lists.freedesktop.org; Lisovskiy, Stanislav
> <stanislav.lisovskiy at intel.com>
> Subject: Re: [v2] drm/i915/display/fbc: Disable fbc by default on TGL
>
> On Thu, Jul 16, 2020 at 08:28:57PM +0530, Uma Shankar wrote:
> > Fbc is causing random underruns in CI execution on TGL platforms.
> > Disabling the same while the problem is being debugged and analyzed.
> >
> > v2: Moved the check below the module param check (Ville)
> >
> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Signed-off-by: Uma Shankar <uma.shankar at intel.com>
>
> Acked-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
This is pushed to dinq. Thanks for the review.
Regards,
Uma Shankar
> > ---
> > drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> > index 3a4f980788a6..195b8be4532a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> > @@ -1426,6 +1426,13 @@ static int intel_sanitize_fbc_option(struct
> drm_i915_private *dev_priv)
> > if (!HAS_FBC(dev_priv))
> > return 0;
> >
> > + /*
> > + * Fbc is causing random underruns in CI execution on TGL platforms.
> > + * Disabling the same while the problem is being debugged and analyzed.
> > + */
> > + if (IS_TIGERLAKE(dev_priv))
> > + return 0;
> > +
> > if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)
> > return 1;
> >
> > --
> > 2.22.0
>
> --
> Ville Syrjälä
> Intel
More information about the Intel-gfx
mailing list