[Intel-gfx] [PATCH] drm/i915/selftests: Flush the active barriers before asserting

Thomas Hellström (Intel) thomas_os at shipmail.org
Wed Jul 29 09:39:46 UTC 2020


On 7/28/20 5:33 PM, Chris Wilson wrote:
> Before we peek at the barrier status for an assert, first serialise with
> its callbacks so that we see a stable value.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_context.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c
> index 52af1cee9a94..1f4020e906a8 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_context.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_context.c
> @@ -68,6 +68,8 @@ static int context_sync(struct intel_context *ce)
>   	} while (!err);
>   	mutex_unlock(&tl->mutex);
>   
> +	/* Wait for all barriers to complete (remote CPU) before we check */
> +	i915_active_unlock_wait(&ce->active);
>   	return err;
>   }
>   

Reviewed-by: Thomas Hellström <thomas.hellstrom at intel.com>




More information about the Intel-gfx mailing list