[Intel-gfx] [PATCH 2/3] drm/i915: add syncobj timeline support

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 31 14:30:59 UTC 2020


Quoting Lionel Landwerlin (2020-07-31 14:45:52)
> -               drm_syncobj_replace_fence(syncobj, fence);
> +               if (eb->fences[n].chain_fence) {
> +                       drm_syncobj_add_point(syncobj, eb->fences[n].chain_fence,
> +                                             fence, eb->fences[n].value);

This function remains not acceptable. It is trivial to write an igt test
that causes the DRM_ERROR. A user controllable error message is still
not allowed. If you do not have such a test in your igt series, then that
too is lacking.
-Chris


More information about the Intel-gfx mailing list